Repository navigation
pm-stack NixOS module: fold the fleet-feed collector in (code#3363) - #3368
Merged
Merged
Conversation
The collector moved from the sandbox to the laptop on 2026-10-31 as hand-written units (~/.config/systemd/user/fleet-feed-collector.service + .timer). Declare the service and timer in the pm-stack module like every other component, with the same environment the hand unit carries, so the next nixos-rebuild switch owns its lifecycle and home-manager retires the hand files. The ExecStartPre password-extraction script stays operator-managed in ~/.local/bin, as the hand unit had it.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
dezren39
added a commit
that referenced
this pull request
Nov 1, 2026
The phantom writer blanking /aa is identified: the sandbox host still runs fleet-feed-collector.timer (systemd, system level), installed from the stale ~/git/pm-feed clone (HEAD 2026-10-29, pre-#3349) and restored on every sandbox boot by ~/tools/init.sh. Its collector defaults SUPABASE_PROJECT_REF to the retired muse-dev project (nltgxorqwxhgfzseiirt) while the bws management token (supabase.access-token-muse-cli) is muse-dev2-scoped, so its AA query fails HTTP 403 (verified directly: same token + retired ref = 403 "does not have the necessary privileges"; same token + muse-dev2 ref keihfchslgjetkmnmzra = 201 with the current ainventory batch). Every ~5 min it scp-pushed its AA-absent, session-poor feed over the laptop collector's good feed (~/pm-stack/aggregator symlinks into the aggregator state dir), racing the laptop collector that has owned the feed since the 2026-10-31 move (#3363/#3368). The collector lives on the laptop now (pm-stack NixOS module), so the sandbox-side units are deleted, not updated: remove systemd/fleet-feed-collector.{service,timer} and scripts/install-collector-units.sh, mark push-fleet-feed.sh manual-only, and correct the stale "sandbox collector / pushed feed" descriptions in README, src/feed.ts, src/topology.ts and src/watchdog.ts. The charges confirm-after-delivery contract stays: push-fleet-feed.sh + confirm-charges-surfaced.ts are untouched. Tests: bun test in pm-stack/aggregator — 870 pass, 2 fail, identical on pristine origin/main (pre-existing slice-3 routes failure).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declares the fleet-feed collector service + timer in nixos/services/pm-stack/default.nix, replacing the hand-written units installed when the collector moved to the laptop on 2026-10-31. Environment mirrors the hand unit exactly (paths via the module's home/repo/aggState variables); the ExecStartPre password script stays operator-managed in ~/.local/bin as it was. Parse-checked (nix-instantiate --parse). Closes the wiring gap in code#3363; the switch itself applies it.
Need help on this PR? Tag
@codesmith-botwith what you need.